regression: Duplicated error messages when inviting invalid user to ABAC managed room #37866

KevLehman · 2025-12-18T17:47:50Z

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/ABAC-105

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Refactor
- Improved error handling logic in the invite command to prevent redundant error processing in specific scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

dionisio-bot · 2025-12-18T17:47:54Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-18T17:47:55Z

⚠️ No Changeset found

Latest commit: 802ae9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-18T17:47:57Z

Walkthrough

The change introduces an early return within the MeteorError handling branch of the invite command's error catch block, preventing downstream isStringError-based error handling from executing when a MeteorError is matched. All other error-handling paths remain unaffected.

Changes

Cohort / File(s)	Summary
Error handling refactoring `apps/meteor/app/slashcommands-invite/server/server.ts`	Added early return in MeteorError catch branch to short-circuit subsequent isStringError-based error handling

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Area of focus: Verify that the early return correctly prevents unintended cascade error handling and doesn't mask relevant error information in the MeteorError case.

Possibly related PRs

fix: Wrong invite error message #37851 — Both PRs modify the MeteorError catch branch in the invite command to change how invite errors are handled and reported.
fix: prioritizes federation not allowed error message over user not f… #37364 — Related changes to the invite command flow that prioritize federation error messages in the same MeteorError handling section.

Suggested labels

stat: QA assured

Suggested reviewers

tassoevan
rodrigok

Poem

🐰 A catch block returns with early grace,
No cascading errors take its place,
MeteorError halts the flow so neat,
Error handling now complete! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title directly addresses the main change: fixing duplicated error messages in the invite command's error handling logic for ABAC-managed rooms.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch regression/duplicate-error-message-on-invite

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-18T18:26:42Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	-739B
queue-worker-service	132MiB	132MiB	-591B
ddp-streamer-service	126MiB	126MiB	-919B
account-service	113MiB	113MiB	-445B
authorization-service	111MiB	111MiB	-335B
stream-hub-service	110MiB	110MiB	+526B
presence-service	110MiB	110MiB	-1.2KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 17:41", "12/18 18:26 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 24 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37866
Baseline: develop
Timestamp: 2025-12-18 18:26:41 UTC
Historical data points: 24

Updated: Thu, 18 Dec 2025 18:26:42 GMT

codecov · 2025-12-18T18:50:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.82%. Comparing base (65214b6) to head (802ae9b).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37866      +/-   ##
===========================================
+ Coverage    67.75%   67.82%   +0.07%     
===========================================
  Files         3463     3463              
  Lines       113702   113702              
  Branches     20901    20901              
===========================================
+ Hits         77034    77120      +86     
+ Misses       34501    34407      -94     
- Partials      2167     2175       +8

Flag	Coverage Δ
e2e	`57.19% <ø> (-0.02%)`	⬇️
e2e-api	`45.03% <ø> (+0.98%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…BAC managed room (RocketChat#37866)

Duplicated error messages when inviting invalid user to room

342cd1e

lucas-a-pelegrino approved these changes Dec 18, 2025

View reviewed changes

KevLehman added this to the 7.14.0 milestone Dec 18, 2025

KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Dec 18, 2025

dionisio-bot bot removed the stat: QA assured Means it has been tested and approved by a company insider label Dec 18, 2025

KevLehman changed the title ~~regression: Duplicated error messages when inviting invalid user to ABAC managed room~~ fix: Duplicated error messages when inviting invalid user to ABAC managed room Dec 18, 2025

Merge branch 'develop' into regression/duplicate-error-message-on-invite

802ae9b

KevLehman marked this pull request as ready for review December 18, 2025 18:40

KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Dec 18, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 18, 2025

ggazzo changed the title ~~fix: Duplicated error messages when inviting invalid user to ABAC managed room~~ regression: Duplicated error messages when inviting invalid user to ABAC managed room Dec 18, 2025

ggazzo merged commit 38204e0 into develop Dec 18, 2025
93 of 95 checks passed

ggazzo deleted the regression/duplicate-error-message-on-invite branch December 18, 2025 22:59

gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026

regression: Duplicated error messages when inviting invalid user to A…

6cfb2d5

…BAC managed room (RocketChat#37866)

dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression: Duplicated error messages when inviting invalid user to ABAC managed room #37866

regression: Duplicated error messages when inviting invalid user to ABAC managed room #37866

Uh oh!

KevLehman commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

codecov bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

regression: Duplicated error messages when inviting invalid user to ABAC managed room #37866

regression: Duplicated error messages when inviting invalid user to ABAC managed room #37866

Uh oh!

Conversation

KevLehman commented Dec 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Dec 18, 2025

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

codecov bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KevLehman commented Dec 18, 2025 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Dec 18, 2025 •

edited

Loading

changeset-bot bot commented Dec 18, 2025 •

edited

Loading

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

codecov bot commented Dec 18, 2025 •

edited

Loading